Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change spree_default_credit_card_deperecated cop severity to warning #67

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Change spree_default_credit_card_deperecated cop severity to warning #67

merged 3 commits into from
Nov 24, 2023

Conversation

safafa
Copy link
Collaborator

@safafa safafa commented Nov 16, 2023 •
edited
Loading

Description

We need to update this cop severity to a warning as mentioned in this issue

Severity:

  • - info
  • - refactor
  • - convention (default)
  • - warning
  • - error
  • - fatal

Wrong Code

 user.default_credit_card

Correct Code

 user.wallet.default_wallet_payment_source

Solidus PR Link: # Replace with link to Solidus PR where the change has been made.

Before submitting the PR make sure the following are checked:

  • The PR relates to only one cop with a clear title and description.
  • Feature branch is up-to-date with main (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran and ensured all tests are passing on a development environment.
  • If this is a new cop, added an entry for the cop on /config/default.yml
  • Updated Changelog

@safafa safafa force-pushed the safa/modify-spree-default-credit-card-deprecated-cop branch from db50b85 to 1de6c77 Compare November 16, 2023 13:10
@safafa safafa marked this pull request as ready for review November 16, 2023 13:15
MassimilianoLattanzio
MassimilianoLattanzio approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@MassimilianoLattanzio MassimilianoLattanzio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just make sure you remember to fix the version number after other PRs are merged.

@safafa safafa force-pushed the safa/modify-spree-default-credit-card-deprecated-cop branch from 1de6c77 to 1e55773 Compare November 24, 2023 16:56
@safafa safafa merged commit eaf4b37 into main Nov 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MassimilianoLattanzio MassimilianoLattanzio MassimilianoLattanzio approved these changes

@DanielePalombo DanielePalombo Awaiting requested review from DanielePalombo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@safafa @MassimilianoLattanzio